Remove all font files except WOFF #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
astorije
reviewed
Oct 9, 2016
| @@ -3,11 +3,8 @@ | |||
| var fs = require("fs-extra"); | |||
|
|
|||
| var srcDir = "./node_modules/font-awesome/fonts/"; | |||
| var destDir = "./client/fonts/"; | |||
| var destDir = "./client/css/fonts/"; | |||
There was a problem hiding this comment.
@xPaw, this was pulled to client/fonts/ on purpose. I believe all fonts should be there instead of client/css/fonts/, but this is also a way to locate the fonts installed by our (up and coming) asset pipeline differently.
What do you think?
astorije
reviewed
Oct 9, 2016
| @@ -5,7 +5,8 @@ coverage/ | |||
|
|
|||
| # Built assets created at npm install/prepublish time | |||
| # See https://docs.npmjs.com/misc/scripts | |||
| client/fonts/ | |||
| client/css/fonts/fontawesome-webfont.woff2 | |||
| client/css/fonts/fontawesome-webfont.woff | |||
There was a problem hiding this comment.
Another benefit of putting the installed fonts in client/fonts/ is that we do not have to keep track of the specific file in different configuration/ignore files
|
This is great! A couple comments before approving. |
|
For the record:
|
astorije
approved these changes
Oct 9, 2016
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Remove all font files except WOFF
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WOFF is supported 92% globally (basically everywhere, except for Opera Mini which simply does not support any fonts). WOFF2 is supported 64% globally, pretty much in all latest browsers.