Skip to content

Commit

Permalink
Merge pull request #409 from thelounge/xpaw/sooner-version-check
Browse files Browse the repository at this point in the history
Perform node version check as soon as possible
  • Loading branch information
AlMcKinlay committed Jun 16, 2016
2 parents cfdcd40 + 12551c0 commit 82618a2
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 5 deletions.
10 changes: 10 additions & 0 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
#!/usr/bin/env node
process.chdir(__dirname);

// Perform node version check before loading any other files or modules
// Doing this check as soon as possible allows us to avoid ES6 parser errors or other issues
var pkg = require("./package.json");
if (!require("semver").satisfies(process.version, pkg.engines.node)) {
console.error("=== WARNING!");
console.error("=== The oldest supported Node.js version is", pkg.engines.node);
console.error("=== We strongly encourage you to upgrade, see https://nodejs.org/en/download/package-manager/ for more details\n");
}

require("./src/command-line");
5 changes: 0 additions & 5 deletions src/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,11 +65,6 @@ module.exports = function(options) {
log.info("The Lounge v" + pkg.version + " is now running on", protocol + "://" + config.host + ":" + config.port + "/");
log.info("Press ctrl-c to stop\n");

if (!require("semver").satisfies(process.version, pkg.engines.node)) {
log.warn("The oldest supported Node.js version is ", pkg.engines.node);
log.warn("We strongly encourage you to upgrade, see https://nodejs.org/en/download/package-manager/ for more details\n");
}

if (!config.public) {
manager.loadUsers();
if (config.autoload) {
Expand Down

0 comments on commit 82618a2

Please sign in to comment.