Skip to content

Commit

Permalink
Merge pull request #303 from thelounge/astorije/aria-label-on-buttons
Browse files Browse the repository at this point in the history
Add missing aria-label on icon buttons
  • Loading branch information
astorije committed May 8, 2016
2 parents 29e0717 + 57d7b01 commit a2ca221
Show file tree
Hide file tree
Showing 5 changed files with 14 additions and 14 deletions.
16 changes: 8 additions & 8 deletions client/index.html
Expand Up @@ -34,17 +34,17 @@
</div>
</aside>
<footer id="footer">
<span class="tooltipped tooltipped-n" aria-label="Sign in to The Lounge"><button class="icon sign-in" data-target="#sign-in"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Connect to network"><button class="icon connect" data-target="#connect"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Client settings"><button class="icon settings" data-target="#settings"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Sign out"><button class="icon sign-out" id="sign-out"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Sign in"><button class="icon sign-in" data-target="#sign-in" aria-label="Sign in"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Connect to network"><button class="icon connect" data-target="#connect" aria-label="Connect to network"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Client settings"><button class="icon settings" data-target="#settings" aria-label="Client settings"></button></span>
<span class="tooltipped tooltipped-n" aria-label="Sign out"><button class="icon sign-out" id="sign-out" aria-label="Sign out"></button></span>
</footer>
<div id="main">
<div id="windows">
<div id="chat" class="no-colors"></div>
<div id="sign-in" class="window">
<div class="header">
<button class="lt"></button>
<button class="lt" aria-label="Toggle channel list"></button>
</div>
<form class="container" method="post" action="">
<div class="row">
Expand Down Expand Up @@ -82,7 +82,7 @@ <h1 class="title">Sign in</h1>
</div>
<div id="connect" class="window">
<div class="header">
<button class="lt"></button>
<button class="lt" aria-label="Toggle channel list"></button>
</div>
<form class="container" method="post" action="">
<div class="row">
Expand Down Expand Up @@ -160,7 +160,7 @@ <h2>User preferences</h2>
</div>
<div id="settings" class="window">
<div class="header">
<button class="lt"></button>
<button class="lt" aria-label="Toggle channel list"></button>
</div>
<div class="container">
<div class="row">
Expand Down Expand Up @@ -308,7 +308,7 @@ <h2>About The Lounge</h2>
<div class="inner">
<div class="input">
<label for="input" id="nick"></label>
<button id="submit" type="submit" title="Send"></button>
<button id="submit" type="submit" title="Send" aria-label="Send message"></button>
<input id="input" class="mousetrap">
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion client/views/chan.tpl
@@ -1,7 +1,7 @@
{{#each channels}}
<div data-id="{{id}}" data-target="#chan-{{id}}" data-title="{{name}}" class="chan {{type}}">
<span class="badge{{#if highlight}} highlight{{/if}}" data-count="{{unread}}">{{#if unread}}{{unread}}{{/if}}</span>
<span class="close"></span>
<button class="close" aria-label="Close"></button>
<span class="name" title="{{name}}">{{name}}</span>
</div>
{{/each}}
6 changes: 3 additions & 3 deletions client/views/chat.tpl
@@ -1,11 +1,11 @@
{{#each channels}}
<div id="chan-{{id}}" data-title="{{name}}" data-id="{{id}}" data-type="{{type}}" data-target="#chan-{{id}}" class="chan {{type}}">
<div class="header">
<button class="lt"></button>
<button class="lt" aria-label="Toggle channel list"></button>
{{#equal type "channel"}}
<button class="rt"></button>
<button class="rt" aria-label="Toggle user list"></button>
{{/equal}}
<button class="menu"></button>
<button class="menu" aria-label="Open the context menu"></button>
<span class="title">{{name}}</span>
<span class="topic">{{{parse topic}}}</span>
</div>
Expand Down
2 changes: 1 addition & 1 deletion client/views/msg.tpl
Expand Up @@ -10,7 +10,7 @@
{{#equal type "toggle"}}
<span class="text">
<div class="force-newline">
<button id="toggle-{{id}}" class="toggle-button">···</button>
<button id="toggle-{{id}}" class="toggle-button" aria-label="Toggle prefetched media">···</button>
</div>
{{#if toggle}}
{{partial "toggle"}}
Expand Down
2 changes: 1 addition & 1 deletion client/views/user.tpl
@@ -1,6 +1,6 @@
{{#if users.length}}
<div class="count">
<input class="search" placeholder="{{users users.length}}">
<input class="search" placeholder="{{users users.length}}" aria-label="Search among the user list">
</div>
{{/if}}
<div class="names">
Expand Down

0 comments on commit a2ca221

Please sign in to comment.