Add role attributes in context menus

thelounge · May 10, 2018 · f09c86c · f09c86c
1 parent ca346ba
commit f09c86c
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/client/js/contextMenu.js b/client/js/contextMenu.js
@@ -99,7 +99,10 @@ module.exports = class ContextMenu {
 
 function showContextMenu(contextMenuItems, selectedElement, event) {
 	const target = $(event.currentTarget);
-	const contextMenu = $("<ul>", {id: "context-menu"});
+	const contextMenu = $("<ul>", {
+		id: "context-menu",
+		role: "menu",
+	});
 
 	for (const item of contextMenuItems) {
 		if (item.check(target)) {

diff --git a/client/views/contextmenu_divider.tpl b/client/views/contextmenu_divider.tpl
@@ -1 +1 @@
-<li class="context-menu-divider" />
+<li class="context-menu-divider" aria-hidden="true"></li>
diff --git a/client/views/contextmenu_item.tpl b/client/views/contextmenu_item.tpl
@@ -1,3 +1,3 @@
-<li class="context-menu-item context-menu-{{class}}" data-action="{{action}}"{{#if data}} data-data="{{data}}"{{/if}} tabindex="0">
+<li class="context-menu-item context-menu-{{class}}" data-action="{{action}}"{{#if data}} data-data="{{data}}"{{/if}} tabindex="0" role="menuitem">
 	{{text}}
 </li>