Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holding pageup/pagedown scrolls very slowly #1022

Closed
xPaw opened this issue Apr 8, 2017 · 10 comments
Closed

Holding pageup/pagedown scrolls very slowly #1022

xPaw opened this issue Apr 8, 2017 · 10 comments
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone

Comments

@xPaw
Copy link
Member

xPaw commented Apr 8, 2017

What I assume happens is that previous animation gets stopped, and it scrolls up from that position where the animation stopped.

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 8, 2017
@xPaw xPaw added this to the 2.3.0 milestone Apr 8, 2017
@xPaw xPaw changed the title Holding pageup/pagedown slows very slowly Holding pageup/pagedown scrolls very slowly Apr 8, 2017
@astorije
Copy link
Member

@xPaw, are you still thinking of fixing this for v2.3.0 or that won't make it?

@xPaw
Copy link
Member Author

xPaw commented Apr 23, 2017

Ideally it should.

@AlMcKinlay
Copy link
Member

This is broken again. Jquery is never returning true on container.is(":animated") anymore. We should probably try and figure out why.

@AlMcKinlay AlMcKinlay reopened this May 17, 2017
@bews
Copy link
Contributor

bews commented May 17, 2017

container.stop().animate({ -> container.stop(true, true).animate({ fixes this.

@xPaw
Copy link
Member Author

xPaw commented May 17, 2017

It doesn't exactly fix scrolling while holding the key down.

@AlMcKinlay
Copy link
Member

As this is new functionality, how much do we care about it getting into 2.3.0? It could go into 2.3.1. It's not a hugely major bug, as it adds functionality rather than breaking old functionality. Thoughts?

@bews
Copy link
Contributor

bews commented May 19, 2017

It doesn't exactly fix scrolling while holding the key down.

Have you tried it? Works for me.

@astorije
Copy link
Member

I'm happy with this going to v2.3.1, @YaManicKill. @xPaw?

@AlMcKinlay
Copy link
Member

So, the problem with the fix suggested by @bews is that it seems to jump up a lot more when holding down the key. If you press multiple times, it works nicely, but it's very sudden and jumpy if you hold the key down (but it is at least much quicker than on master).

@AlMcKinlay
Copy link
Member

Right, let's drop this from 2.3.0, and push it to 2.3.1. Let's get 2.3.0 released.

@AlMcKinlay AlMcKinlay modified the milestones: 2.3.0, 2.3.1 May 24, 2017
@astorije astorije modified the milestones: 2.3.2, 2.3.1 Jun 9, 2017
eliemichel pushed a commit to eliemichel/lounge that referenced this issue Aug 31, 2017
eliemichel pushed a commit to eliemichel/lounge that referenced this issue Aug 31, 2017
matburnham pushed a commit to matburnham/lounge that referenced this issue Sep 6, 2017
matburnham pushed a commit to matburnham/lounge that referenced this issue Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

No branches or pull requests

4 participants