New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Holding pageup/pagedown scrolls very slowly #1022
Comments
@xPaw, are you still thinking of fixing this for v2.3.0 or that won't make it? |
Ideally it should. |
This is broken again. Jquery is never returning true on container.is(":animated") anymore. We should probably try and figure out why. |
|
It doesn't exactly fix scrolling while holding the key down. |
As this is new functionality, how much do we care about it getting into 2.3.0? It could go into 2.3.1. It's not a hugely major bug, as it adds functionality rather than breaking old functionality. Thoughts? |
Have you tried it? Works for me. |
I'm happy with this going to v2.3.1, @YaManicKill. @xPaw? |
So, the problem with the fix suggested by @bews is that it seems to jump up a lot more when holding down the key. If you press multiple times, it works nicely, but it's very sudden and jumpy if you hold the key down (but it is at least much quicker than on master). |
Right, let's drop this from 2.3.0, and push it to 2.3.1. Let's get 2.3.0 released. |
What I assume happens is that previous animation gets stopped, and it scrolls up from that position where the animation stopped.
The text was updated successfully, but these errors were encountered: