Client lib used by server code is missing from the 2.6.0-rc.1 release

[astorije]

This file is trying to load another file from client/js/..., which are ignored in our release since #1611, as shown here:

(module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
2017-11-12 05:21:18 [INFO] The Lounge v2.6.0-rc.1 (node 4.8.6 on linux x64)
2017-11-12 05:21:18 [INFO] Configuration file: /etc/lounge/config.js
2017-11-12 05:21:18 [INFO] Available at http://127.0.0.1:9000/ in private mode
module.js:327
    throw err;
    ^

Error: Cannot find module '../../../client/js/libs/handlebars/ircmessageparser/findLinks'
    at Function.Module._resolveFilename (module.js:325:15)
    at Function.Module._load (module.js:276:25)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)
    at Object.<anonymous> (/usr/lib/node_modules/thelounge/src/plugins/irc-events/link.js:7:19)
    at Module._compile (module.js:409:26)
    at Object.Module._extensions..js (module.js:416:10)
    at Module.load (module.js:343:32)
    at Function.Module._load (module.js:300:12)
    at Module.require (module.js:353:17)
    at require (internal/module.js:12:17)

There was a recent issue with webpack-cleanup-plugin deleting all files in client/ I believe (see #1682). Could it be that webpack-cleanup-plugin cleans up the same things than listed in the .npmignore file?

[astorije]

@xPaw, a quick-and-dirty fix would be to un-ignore that specific file (the only client file used by server code) until something better, but I'm thinking you might have a better idea so I'll leave you this one (it's pretty late here anyway).

I'll release a rc.2 when we have a fix. How thankful I am for pre-releases...

[xPaw]

It's either unignoring that file, moving it to src folder or making a shared folder.

[astorije]

Mind opening a PR if you can? It's too late for me to do something about it right now :/