Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Not trim space on Network Settings > Server #4521

Closed
EVOTk opened this issue Apr 3, 2022 · 3 comments · Fixed by #4623
Closed

Not trim space on Network Settings > Server #4521

EVOTk opened this issue Apr 3, 2022 · 3 comments · Fixed by #4623
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Milestone
5.0.0

Comments

@EVOTk
Copy link

EVOTk commented Apr 3, 2022 •
edited

  • Browser version: Firefox 98.0.2 (64 bits)
  • Device, operating system: Windows 10
  • The Lounge version: v4.3.0

Hello,
Would it be possible to automatically erase the spaces before and after the Network Settings > Server field?
A bad copy/paste with a space before or after the server address makes the connection impossible.

Exemple :

  • irc.libera.chat Work
  • irc.libera.chat Not Work *
  • irc.libera.chat Not Work

* Github trim the first space ^^

Moreover the error is not explicit because removes this additional space

Thx

2022-04-03 18_19_53-The Lounge
2022-04-03 18_20_25-Libera Chat — The Lounge
@EVOTk EVOTk added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 3, 2022
@brunnre8 brunnre8 removed the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Apr 3, 2022
brunnre8 added a commit that referenced this issue Apr 4, 2022
@brunnre8
connect: Trim white space from user input fields
8d418bf 
Fixes: #4521
@brunnre8
Copy link
Member

brunnre8 commented Apr 4, 2022

It would make sense to do that, yes.
If you could test the commit referenced above that'd be great

@EVOTk
Copy link
Author

EVOTk commented Apr 6, 2022

Hello,
Thank you so much for your quick fix!
Unfortunately I don't have strong development skills. I have a simple install of thelougne in docker and I don't know how to test your fix :(

brunnre8 added a commit that referenced this issue Aug 28, 2022
@brunnre8
connect: Trim white space from user input fields
883acc1 
Fixes: #4521
@brunnre8 brunnre8 mentioned this issue Aug 28, 2022
Merged
MaxLeiter pushed a commit that referenced this issue Sep 8, 2022
@brunnre8
connect: Trim white space from user input fields (#4623)
0fa2035 
Fixes: #4521
@MaxLeiter MaxLeiter added this to the 5.0.0 milestone Sep 8, 2022
@MaxLeiter MaxLeiter added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Sep 8, 2022
@MaxLeiter
Copy link
Member

Thanks for the report @EVOTk! The fix has been merged and will be available in the next release. If you'd like it in the meantime, you can build from git.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

connect: Trim white space from user input fields thelounge/thelounge
3 participants
@MaxLeiter @brunnre8 @EVOTk