Do not hardcode vendor bundles in webpack #1280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Feature
astorije
changed the title
astorije
reviewed
Jun 30, 2017
| // automatically split all vendor dependancies into a separate bundle | ||
| new webpack.optimize.CommonsChunkPlugin({ | ||
| name: "js/bundle.vendor.js", | ||
| minChunks: (module) => module.context && module.context.indexOf("node_modules") !== -1 |
There was a problem hiding this comment.
How does this know what packages to build into the vendor bundle specifically?
There was a problem hiding this comment.
node_modules being in the path.
There was a problem hiding this comment.
Right, that tells Webpack where are our packages, but is it going to load everything that's under node_modules (like lodash, that we don't use in the client)? Or is it the other way around, it discovers everything that's require()d, then puts them in the right file based on this line?
There was a problem hiding this comment.
It's based on requires. Basically it generates identical bundles to what master has now.
astorije
approved these changes
Jul 4, 2017
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Do not hardcode vendor bundles in webpack
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.