Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title attributes to previews #1291

Merged
merged 1 commit into from Jul 4, 2017
Merged

Add title attributes to previews #1291

merged 1 commit into from Jul 4, 2017

Conversation

astorije
Copy link
Member

@astorije astorije commented Jul 3, 2017

This is useful on long preview titles/descriptions that truncate. We currently do the same for topics.

screen shot 2017-07-03 at 02 39 00

@astorije astorije added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Jul 3, 2017
@astorije astorije added this to the 2.3.3 milestone Jul 3, 2017
@astorije astorije requested a review from xPaw July 3, 2017 06:40
This is useful on long preview titles/descriptions that truncate. We currently do the same for topics
@xPaw xPaw merged commit 81e9a20 into master Jul 4, 2017
@xPaw xPaw deleted the astorije/title-previews branch July 4, 2017 17:19
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants