Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default /quit message #1448

Merged
merged 1 commit into from Aug 26, 2017
Merged

Set default /quit message #1448

merged 1 commit into from Aug 26, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Aug 23, 2017

No description provided.

@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Aug 23, 2017
src/client.js Outdated
@@ -501,7 +501,7 @@ Client.prototype.quit = function() {
}
this.networks.forEach((network) => {
if (network.irc) {
network.irc.quit("Page closed");
network.irc.quit(`Page closed - ${pkg.homepage}`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't use "Page closed" + leaveMessage?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too long for my liking

Copy link
Member

@astorije astorije left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice addition!

@xPaw xPaw added this to the 2.5.0 milestone Aug 26, 2017
@xPaw xPaw merged commit 495d8c3 into master Aug 26, 2017
@xPaw xPaw deleted the xpaw/quit-promo branch August 26, 2017 17:34
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@astorije astorije changed the title Set default quit default message Set default /quit message Sep 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants