Completely refactor how date markers are inserted #1452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Type: Bug
|
Hey @xPaw, unfortunately...
|
xPaw
force-pushed
the
xpaw/refactor-dates
branch
from
29f1e61
to
e86e311
Compare
|
@astorije I refactored it even further, fixed your bug and found another bug which I also fixed. |
xPaw
force-pushed
the
xpaw/refactor-dates
branch
3 times, most recently
from
46c7c6c
to
32e37b4
Compare
astorije
reviewed
Aug 26, 2017
client/js/render.js
Outdated
| msg: message | ||
| })); | ||
| function buildChannelMessages(chanId, chanType, messages) { | ||
| return messages.reduce(function(docFragment, message) { |
There was a problem hiding this comment.
Nitpick: return messages.reduce((docFragment, message) => {
astorije
reviewed
Aug 26, 2017
| const msgTime = new Date(msg.time); | ||
|
|
||
| // It's the first message in a window, | ||
| // then just append the message and do nothing else |
There was a problem hiding this comment.
An idea for a future PR would be to display the date marker if it's the first message in a window and there is no "more" button available. Reason for this would be to remove that odd situation that #1318 shows (I know it's not creating it, just making it more obvious).
astorije
reviewed
Aug 26, 2017
| return docFragment; | ||
| }, $(document.createDocumentFragment())); | ||
| } | ||
|
|
||
| function appendMessage(container, chan, chanType, messageType, msg) { | ||
| function appendMessage(container, chanId, chanType, msg) { |
There was a problem hiding this comment.
This method could use a test or 2, but not blocking this PR obviously.
xPaw
force-pushed
the
xpaw/refactor-dates
branch
from
32e37b4
to
f1a8598
Compare
xPaw
force-pushed
the
xpaw/refactor-dates
branch
from
f1a8598
to
9940042
Compare
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
Completely refactor how date markers are inserted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1450 and most likely other subtle bugs.