Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add tests for invalid urls #1620

Merged
merged 1 commit into from Oct 7, 2017
Merged

Add tests for invalid urls #1620

merged 1 commit into from Oct 7, 2017

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Oct 6, 2017

No description provided.

@xPaw xPaw added this to the 2.5.0 milestone Oct 6, 2017
@xPaw xPaw added the Type: Feature Tickets that describe a desired feature or PRs that add them to the project. label Oct 6, 2017
astorije
astorije reviewed Oct 6, 2017
View reviewed changes
test/client/js/libs/handlebars/ircmessageparser/findLinks.js

const actual = findLinks(input);

expect(actual).to.deep.equal(expected);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be its own "should add http protocol to urls starting with www" or something, no?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example doesn't matter here, the test is for the second URL.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mmh ok

@astorije astorije merged commit c2681a9 into master Oct 7, 2017
@astorije astorije deleted the xpaw/invalid-uri-test branch October 7, 2017 02:21
@astorije astorije added Meta: Internal This is an internal codebase change (testing, linting, etc.). Meta: Skip Changelog This issue should not appear in the changelog. Will be skipped by the changelog generator. and removed Meta: Skip Changelog This issue should not appear in the changelog. Will be skipped by the changelog generator. labels Oct 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

Assignees
No one assigned
Labels
Meta: Internal This is an internal codebase change (testing, linting, etc.). Type: Feature Tickets that describe a desired feature or PRs that add them to the project.
Projects
None yet
Milestone
2.5.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@xPaw @astorije