Revert "Allow The Lounge to be proxied behind a /path/ url" #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Bug
|
Merging this revert as-is as |
astorije
added a commit
that referenced
this pull request
Feb 13, 2016
Revert "Allow The Lounge to be proxied behind a /path/ url"
|
socket.io is idiotic. I'll send a new pull request |
|
OTOH. that hard |
|
@gdamjan Yeah, I've got a branch on my fork to remove that because it's actually unneessary (socket io reconnects fine) but I'm testing it out irl for a while before merging it back. |
|
Agreed @gdamjan and @YaManicKill, sorry I didn't investigate more to fix this, but first I wouldn't have merge without having a review if I had tried to fix the issue (while a revert is an emergency feature), and it was the middle of the night, I merely wanted to fix master. |
brunnre8
pushed a commit
to brunnre8/thelounge
that referenced
this pull request
Apr 6, 2021
Remove lounge commands
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #20
This PR breaks The Lounge: as
./socket.io/cannot be found, the client restarts in loop many times per second.@gdamjan, sorry for merging too soon, would you mind taking a look at this? Thanks!