Reduce lightness of low contrast nick colors to reach AA level of WCAG 2.0 #2282
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I know this is going to make some people unhappy, but some of our nick colors were outrageously low-contrasted. Some of them were even very far from accessible color contrast guidelines.
So rather than doing it by ear (well, eye), which would be subjective and always upset someone, I went with something more objective:
That way, I keep the same Hue and Saturation, in order to keep colors as close to their original ones.
There will be values close to each others, some that people will dislike on their own nick, but I thought this would be the most fair way to get decent values.
Some before/after examples from the user list:
And if interested, the before/after on colors themselves (remember that effect of color on text is different than background, what seems fairly visible in background might actually be very difficult to see once on text):
If I ever need to generate this again