Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix up link insertion after uploads to be saner #3011

Merged
merged 1 commit into from Feb 2, 2019
Merged

Fix up link insertion after uploads to be saner #3011

merged 1 commit into from Feb 2, 2019

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Jan 30, 2019

  • If there's text before cursor, it will add a space before the url
  • Will always put the cursor after the link + space
  • Will no longer override selected text, instead will insert it where the selection starts

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Jan 30, 2019
@xPaw xPaw added this to the 3.0.1 milestone Jan 30, 2019
@xPaw xPaw merged commit 0f4e29d into master Feb 2, 2019
@xPaw xPaw deleted the xpaw/upload-cursor branch February 2, 2019 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MaxLeiter MaxLeiter MaxLeiter left review comments

@astorije astorije astorije approved these changes

@richrd richrd richrd approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
3.0.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@xPaw @astorije @richrd @MaxLeiter