Pretend to be facebook and twitter bots in link prefetcher #3602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xPaw
added
the
Meta: Internal
|
Yeah, why not. I don't see any harm in this. |
richrd
approved these changes
Dec 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is not my idea. Apple does this in iMessages.
When using lounge's UA, to get to the
<title>tag, you have to download >600kb of content for some reason. Lounge limits to 50kb and cuts off so we don't get any previews on amazon.Adding facebook to the UA makes amazon serve opengraph tags, and we get a proper preview.
See https://24ways.org/2019/microbrowsers-are-everywhere/
https://peter.upfold.org.uk/blog/2019/02/23/when-is-imessage-not-imessage-when-its-facebookexternalhit-1-1/
@thelounge/maintainers Do you think this is fine?