Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vertically center topic editing input in Safari. #4325

Merged
merged 1 commit into from
Oct 10, 2021

Conversation

itsjohncs
Copy link
Member

It was significantly misaligned. Change tested on recent Chrome,
Safari, and Firefox on Mac OS X.

--

Before

Screenshot of topic bar. The bounds of the text input is vertically off center, pushed upwards significantly.

After

Screenshot of topic bar without alignment issues

@itsjohncs itsjohncs changed the title Vertically-center topic editing input in Safari. Vertically center topic editing input in Safari. Oct 9, 2021
It was significantly misaligned. Change tested on recent Chrome,
Safari, and Firefox on Mac OS X.
@MaxLeiter MaxLeiter merged commit 2ab6716 into thelounge:master Oct 10, 2021
@itsjohncs itsjohncs deleted the topic-safari-misalignment branch October 10, 2021 07:59
@MaxLeiter MaxLeiter added this to the 4.3.0 milestone Oct 11, 2021
@MaxLeiter MaxLeiter added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Oct 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants