Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill The Lounge process when ident can't start up #4512

Merged
merged 1 commit into from
Apr 12, 2022
Merged

Kill The Lounge process when ident can't start up #4512

merged 1 commit into from
Apr 12, 2022

Conversation

brunnre8
Copy link
Member

Fixes: #4509

itsjohncs
itsjohncs approved these changes Mar 13, 2022
View reviewed changes
Copy link
Member

@itsjohncs itsjohncs left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense 👍.

Didn't test but took a pretty close look at the code.

@brunnre8 brunnre8 added Status: release-after-next reviewed and ready to merge, postponed to release after next (feature freeze of current release) Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. labels Mar 15, 2022
@MaxLeiter MaxLeiter removed the Status: release-after-next reviewed and ready to merge, postponed to release after next (feature freeze of current release) label Apr 12, 2022
@MaxLeiter MaxLeiter changed the title Kill TL when ident can't start up Kill The Lounge process when ident can't start up Apr 12, 2022
@MaxLeiter MaxLeiter merged commit 37d7de7 into master Apr 12, 2022
@MaxLeiter MaxLeiter deleted the bookworm/identAbort branch April 12, 2022 00:45
@MaxLeiter MaxLeiter added this to the 4.3.2 milestone Apr 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@itsjohncs itsjohncs itsjohncs approved these changes

@JeDaYoshi JeDaYoshi JeDaYoshi approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Error when can't bind for ident server, but doesn't exits
4 participants
@brunnre8 @itsjohncs @JeDaYoshi @MaxLeiter