Fix the alignment of the header buttons #4539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is Fix topic wrapping on mobile meant to be in this PR? You only have screenshots and a description for the header button alignment. |
itsjohncs
added
Type: Bug
Yes. The original commit caused unintentional topic wrapping bug on mobile devices. Both commits are of this PR and needed this to work. |
MaxLeiter
added
Status: needs-review
itsjohncs
approved these changes
Apr 18, 2022
|
Thanks @ronilaukkarinen! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
After this PR:
That margin there is unnecessary and causes some themes/fonts to align incorrectly.
align-items: center;and margin reset make sure incorrect alignment is not happening in any scenario.