Fix yarn dev #4574
Merged
Fix yarn dev #4574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests dont seem to be happy with this change |
brunnre8
reviewed
May 18, 2022
| @@ -6,7 +6,7 @@ module.exports = (app) => { | |||
| log.debug("Starting server in development mode"); | |||
|
|
|||
| const webpack = require("webpack"); | |||
| const webpackConfig = require("../../webpack.config.js"); | |||
| const webpackConfig = require("../../webpack.config.js")(undefined, {mode: "production"}); | |||
There was a problem hiding this comment.
src/plugins/dev-server.js does in fact use the production webpack config. This is one commit before the cjs changes i PR'd
thelounge/src/plugins/dev-server.js
Line 9 in 5f7acbf
MaxLeiter
approved these changes
May 21, 2022
MaxLeiter
added
the
Type: Bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This may significantly change how the webpack development config behaves. Instead of replacingentryandpluginsthis will append to the existing values. This makes the dev-server use the webpack development config (previously it used production).Completely rewrote the changes here. Main thing is the mini css extract was needed in the dev webpack config mode.
Also added using
output.cleanhttps://webpack.js.org/configuration/output/#outputclean instead of removing files from the output directory manually.