Remove uploading event listeners on ChatInput unmount #4600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxLeiter
added
the
Type: Bug
MaxLeiter
commented
Jun 26, 2022
| @@ -11,12 +11,18 @@ class Uploader { | |||
| overlay: HTMLDivElement | null = null; | |||
| uploadProgressbar: HTMLSpanElement | null = null; | |||
|
|
|||
| onDragEnter = (e: DragEvent) => this.dragEnter(e); | |||
There was a problem hiding this comment.
we have to pass a reference as the second arg to removeEventListener for it to work properly, hence these functions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not too sure how this worked in Vue 2, but we weren't removing the event listeners in Upload so you could cause an error pasting/dragging on a not-chat page.