Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ctcp request message #4603

Merged
merged 1 commit into from
Jul 7, 2022
Merged

Fix ctcp request message #4603

merged 1 commit into from
Jul 7, 2022

Conversation

brunnre8
Copy link
Member

@brunnre8 brunnre8 commented Jul 3, 2022

The message was ordered the wrong way in the TS rewrite.

Old:
+bookworm sent a CTCP request: "chadler" to version
New:
+bookworm sent a CTCP request: "version" to chadler

The message was ordered the wrong way in the TS rewrite.

Old:
    +bookworm sent a CTCP request: "chadler" to version
New:
    +bookworm sent a CTCP request: "version" to chadler
@brunnre8 brunnre8 requested a review from MaxLeiter July 3, 2022 16:49
@brunnre8 brunnre8 added Status: needs-review PR not yet reviewed by enough maintainers Status: Regression PR that introduced a regression and needs a fix labels Jul 3, 2022
@MaxLeiter MaxLeiter merged commit c8cd405 into master Jul 7, 2022
@MaxLeiter MaxLeiter deleted the bookworm/ctcp branch July 7, 2022 05:28
@MaxLeiter MaxLeiter added this to the 5.0.0 milestone Jul 9, 2022
@MaxLeiter MaxLeiter added Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. and removed Status: needs-review PR not yet reviewed by enough maintainers labels Jul 9, 2022
@MaxLeiter MaxLeiter modified the milestones: 5.0.0, 4.4.0 Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Regression PR that introduced a regression and needs a fix Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants