Added client type checking to webpack #4619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brunnre8
requested changes
Aug 14, 2022
There was a problem hiding this comment.
Thanks a bunch for your help here, build system work is not particularly fun to do so that's very much appreciated.
There are some areas where we should be a bit more careful with the error handling though, rather than just asserting things we can't possibly guarantee.
Mind fixing those up?
There's also some questions out of interest.
brunnre8
added
Meta: Internal
antoniomika
force-pushed
the
am/client-type-checking
branch
2 times, most recently
from
c3991ae
to
4d15fb7
Compare
brunnre8
reviewed
Aug 14, 2022
antoniomika
force-pushed
the
am/client-type-checking
branch
from
4d15fb7
to
8485761
Compare
brunnre8
added
Status: needs-review
MaxLeiter
requested changes
Aug 16, 2022
|
Thank you! This seems to work great. I left one small comment and then I'm okay with merging. |
MaxLeiter
added
Status: changes-requested
MaxLeiter
removed
the
Status: changes-requested
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes changes to add type checking (via TypeScript) for the client-side code base. webpack does not currently report TypeScript errors (which poses an issue).
This was done out of a message on IRC via @MaxLeiter.
The changes here are broken up between two commits, one to enable type checking and another to fix the issues the compiler has found.