Add edge case checks and rework logic friendlysize #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettgilio
changed the title
|
why are you rewriting this code? |
Largely to handle edge cases. I noticed them when I was viewing the file to extend @4662. |
brunnre8
requested changes
Dec 25, 2022
|
|
||
| const i = Math.floor(Math.log(size) / Math.log(1024)); | ||
|
|
||
| if (i >= sizes.length) { |
There was a problem hiding this comment.
this must not error, simply emit a large number
There was a problem hiding this comment.
To be clear you just want it to emit the KB value?
There was a problem hiding this comment.
why KB?
You are guarding the index value, simply pick the highest available one namely sizes.length and do the dance same as you did in the other patch.
brunnre8
added
Meta: Internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #4662