Decouple server #4686
Merged
Decouple server #4686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the first step to sever any dependency of the server on the client
This decouples the rest of the server from the client
All files are specified in the individual sub projects
xPaw
added
the
Meta: Internal
brunnre8
added
the
Status: needs-review
MaxLeiter
reviewed
Feb 25, 2023
| @@ -2,7 +2,7 @@ import anyIntersection from "./anyIntersection"; | |||
| import fill from "./fill"; | |||
| import {ChannelPart} from "./findChannels"; | |||
| import {EmojiPart} from "./findEmoji"; | |||
| import {LinkPart} from "./findLinks"; | |||
| import {LinkPart} from "../../../../shared/linkify"; | |||
There was a problem hiding this comment.
eventual TODO: typescript path aliases would let us import something like #/shared/linkify
MaxLeiter
approved these changes
Feb 25, 2023
MaxLeiter
removed
the
Status: needs-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We should eventually decouple both server from client and client from server.
Shared stuff should move to shared/ or some such.
This decouples the server from the client, in a first step as that's the easier one