Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix config typing and make Client easier to test #4711

Merged
merged 4 commits into from
Mar 17, 2023
Merged

Fix config typing and make Client easier to test #4711

merged 4 commits into from
Mar 17, 2023

Commits on Mar 15, 2023

  1. Fix incorrect typing of dehydrated networks and channels 

    Client and ClientManager deal with both 'dehydrated' channels/networks (ie. directly
from JSON configuration) and the 'rehydrated' ones (classes, with socket objects,
message arrays, etc.).

However, because their attributes are similar, both types were used interchangeably,
which becomes an issue when splitting Client's configuration loading into smaller
methods.
    @progval
    progval committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    76098d7 View commit details
    Browse the repository at this point in the history

  2. Client: move socket connection out of the constructor 

    It will make it easier to write tests for what used to be in
the connect() method
    @progval
    progval committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    a049a01 View commit details
    Browse the repository at this point in the history

  3. Fix test wording

    @progval
    progval committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    d58fb84 View commit details
    Browse the repository at this point in the history

  4. Remove override of UserConfig

    @progval
    progval committed Mar 15, 2023
    Configuration menu
    Copy the full SHA
    320075e View commit details
    Browse the repository at this point in the history