Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve font icon management, sizing and sharpness #493

Merged
merged 4 commits into from Jul 22, 2016
Merged

Improve font icon management, sizing and sharpness #493

merged 4 commits into from Jul 22, 2016

Commits on Jul 22, 2016

  1. Improve font icon rendering with font-smoothing 

    This makes all icons look sharper, and reproduces what is applied on the FontAwesome CSS:
https://github.com/FortAwesome/Font-Awesome/blob/4213679/css/font-awesome.css#L19-L20
    @astorije
    astorije committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    1f59dec View commit details
    Browse the repository at this point in the history

  2. Define icon font only once and fix sizing 

    This commit applies the following across the whole style:

- `font` statement is now the same as official FontAwesome CSS
- Ensure icons are never italic or bold or that other variants can be
  applied
- Ensure font-size and line-height of icons are inherited from parent
- font-family and font-smoothing is now defined only once

A few (mostly positive) side effects from these and related changes:

- Header icons (main menu, context menu and user list) are now
  vertically centered!
- Same applies to the Send icon, but it's more subtle there
- Alignment of the footer icons are shifted a tiny bit
- Server window icons are a wee bit bit bigger to match the server name
  font-size
- The "Play sound" icon and text are now both 14px (was 14px / 16px)
    @astorije
    astorije committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    a898f46 View commit details
    Browse the repository at this point in the history

  3. Add/fix/remove some CSS transitions 

    - Transition on the search icon was removed, because why was it even
  here?!
- A transition was added to the "Play sound" button
- Transition on the Send button is now consistent with the others
    @astorije
    astorije committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    5f558ab View commit details
    Browse the repository at this point in the history

  4. Centralize all icon definitions for better management

    @astorije
    astorije committed Jul 22, 2016
    Configuration menu
    Copy the full SHA
    e3d80d4 View commit details
    Browse the repository at this point in the history