Make custom highlights case-insensitive #565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
astorije
added
the
Type: Feature
| @@ -287,8 +287,8 @@ <h1 class="title">Settings</h1> | |||
|
|
|||
| <div class="col-sm-12"> | |||
| <label class="opt"> | |||
| <label for="highlights" class="sr-only">Custom highlights (comma-separated keywords)</label> | |||
| <input type="text" id="highlights" name="highlights" class="input" placeholder="Custom highlights (comma-separated keywords)"> | |||
| <label for="highlights" class="sr-only">Custom highlights (comma-separated keywords, case-insensitive)</label> | |||
There was a problem hiding this comment.
Not convinced about adding this to the label/placeholder, tbh. I think this would be expected as the default.
I guess the other option would be to put a checkbox for case sensitivity. But either way, I wouldn't put this in the label/placeholder.
|
👍 despite my 1 comment. Not massively against the extra characters, but I don't think necessary |
astorije
force-pushed
the
astorije/439-case-insensitive-highlights
branch
from
c77152a
to
d48830a
Compare
|
@YaManicKill, I updated my PR to address your comment. We can improve this over time, no big deal. Fixing the underlying issue is more pressing anyway. |
|
I am still 👍 |
|
Cool! @maxpoulin64? |
matburnham
pushed a commit
to matburnham/lounge
that referenced
this pull request
Sep 6, 2017
…ensitive-highlights Make custom highlights case-insensitive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #439.