Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Silence failures to trigger notifications when not available #732

Merged
merged 2 commits into from Nov 16, 2016
Merged

Silence failures to trigger notifications when not available #732

merged 2 commits into from Nov 16, 2016

Commits on Nov 8, 2016

  1. Silence failures to trigger notifications when not available 

    Recent Chrome versions are dropping out `new Notification` in favor of `ServiceWorkerRegistration.showNotification`.
This makes sure nothing bad happens until we have proper support for Service Workers.

See:
- https://stackoverflow.com/questions/29774836/failed-to-construct-notification-illegal-constructor
- https://stackoverflow.com/questions/31512504/html5-notification-not-working-in-mobile-chrome
    @astorije
    astorije committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    e21ec8b View commit details
    Browse the repository at this point in the history

  2. Prevent sound notification to throw an exception on mobile

    @astorije
    astorije committed Nov 8, 2016
    Configuration menu
    Copy the full SHA
    dff1a48 View commit details
    Browse the repository at this point in the history