Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #792: irc-fw update changed socket reference #802

Merged
merged 1 commit into from Dec 17, 2016
Merged

Fix #792: irc-fw update changed socket reference #802

merged 1 commit into from Dec 17, 2016

Conversation

xPaw
Copy link
Member

@xPaw xPaw commented Dec 16, 2016 •
edited by astorije

Fix #792

@xPaw xPaw added the Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors. label Dec 16, 2016
@xPaw xPaw added this to the 2.2.0 milestone Dec 16, 2016
@xPaw
Copy link
Member Author

xPaw commented Dec 16, 2016

Unsure why @maxpoulin64 switched the event for getting the socket here 9aafffd#diff-55248618acffb7cdf06e24e021c51cab

00:10 prawnsalad 'raw socket connected' event if youre using the default transport, includes the socket as the first arg
00:10 prawnsalad if you were using any other event for it previously, then some of your identd lookups were broken
00:11 prawnsalad identd lookup could come in before SSL handshake has finished and triggered 'connected' for example

@maxpoulin64 maxpoulin64 merged commit 8ba34f1 into master Dec 17, 2016
@maxpoulin64 maxpoulin64 deleted the xpaw/irc-fw-socket-fix branch December 17, 2016 01:37
matburnham pushed a commit to matburnham/lounge that referenced this pull request Sep 6, 2017
@maxpoulin64
Merge pull request thelounge#802 from thelounge/xpaw/irc-fw-socket-fix
b31c8f9 
Fix thelounge#792: irc-fw update changed socket reference
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astorije astorije astorije approved these changes

@maxpoulin64 maxpoulin64 maxpoulin64 approved these changes

Assignees
No one assigned
Labels
Type: Bug Issues that report and PRs that solve any defects that cause unexpected behaviors.
Projects
None yet
Milestone
2.2.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xPaw @astorije @maxpoulin64