Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: check email if verified before set password and fix typing #3529

Merged
merged 5 commits into from
Aug 25, 2023

Conversation

gary02
Copy link
Contributor

@gary02 gary02 commented Aug 11, 2023

  • check email if verified before set password
  • correct user.email type to be string | null and pass build

@gary02 gary02 requested a review from a team as a code owner August 11, 2023 09:01
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Patch coverage: 14.28% and project coverage change: +1.55% 🎉

Comparison is base (044aa46) 49.56% compared to head (68b86e8) 51.11%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3529      +/-   ##
===========================================
+ Coverage    49.56%   51.11%   +1.55%     
===========================================
  Files          518      518              
  Lines        12574    12579       +5     
  Branches      2870     2873       +3     
===========================================
+ Hits          6232     6430     +198     
+ Misses        5709     5526     -183     
+ Partials       633      623      -10     
Files Changed Coverage Δ
src/connectors/queue/payout.ts 25.31% <0.00%> (-0.66%) ⬇️
src/mutations/user/addCredit.ts 18.18% <0.00%> (ø)
src/mutations/user/payout.ts 40.62% <ø> (-0.56%) ⬇️
src/mutations/user/setPassword.ts 50.00% <0.00%> (ø)
src/connectors/userService.ts 52.07% <20.00%> (+1.36%) ⬆️
src/mutations/circle/subscribeCircle.ts 70.96% <50.00%> (-0.70%) ⬇️

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/mutations/user/addCredit.ts Show resolved Hide resolved
@gary02 gary02 linked an issue Aug 11, 2023 that may be closed by this pull request
3 tasks
@gary02 gary02 merged commit e3cab40 into develop Aug 25, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/set-password branch August 25, 2023 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Email: revise password mechanisms
2 participants