Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(notice): revise default notification settings #3547

Merged
merged 9 commits into from
Aug 23, 2023

Conversation

robertu7
Copy link
Contributor

@robertu7 robertu7 commented Aug 18, 2023

  • Revise default notification settings;
  • Skip sending email from root mail connector;
  • Remove tag related notices;
  • Remove subscribed_article_new_comment notice;
  • Ignore warning by adding --ignore to lint command;

Note:
Some changes are inherited from #3529, will resolve conflicts later.

@robertu7 robertu7 requested a review from a team as a code owner August 18, 2023 08:05
@robertu7 robertu7 changed the title feat(notice): revise default notification settings WIP: feat(notice): revise default notification settings Aug 18, 2023
@robertu7 robertu7 requested a review from gary02 August 18, 2023 08:05
@robertu7 robertu7 force-pushed the feat/default-notice-settings branch from a711795 to ade656d Compare August 22, 2023 08:06
@robertu7 robertu7 changed the title WIP: feat(notice): revise default notification settings feat(notice): revise default notification settings Aug 22, 2023
@robertu7 robertu7 force-pushed the feat/default-notice-settings branch from c22f1fb to dee6dcc Compare August 22, 2023 10:36
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage: 54.54% and project coverage change: -1.29% ⚠️

Comparison is base (6e566bb) 50.67% compared to head (300a2b2) 49.39%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3547      +/-   ##
===========================================
- Coverage    50.67%   49.39%   -1.29%     
===========================================
  Files          521      519       -2     
  Lines        12743    12588     -155     
  Branches      2906     2879      -27     
===========================================
- Hits          6458     6218     -240     
- Misses        5664     5744      +80     
- Partials       621      626       +5     
Files Changed Coverage Δ
db/seeds/14_notice.js 100.00% <ø> (ø)
src/common/enums/notification.ts 100.00% <ø> (ø)
src/common/utils/getViewer.ts 36.25% <ø> (ø)
src/connectors/notificationService/index.ts 55.91% <ø> (-10.09%) ⬇️
src/connectors/notificationService/mail/index.ts 100.00% <ø> (ø)
...s/notificationService/mail/sendCircleInvitation.ts 100.00% <ø> (ø)
...s/notificationService/mail/sendMigrationSuccess.ts 55.55% <ø> (ø)
...connectors/notificationService/mail/sendPayment.ts 50.00% <ø> (ø)
...rs/notificationService/mail/sendRegisterSuccess.ts 88.88% <ø> (ø)
...notificationService/mail/sendUserDeletedByAdmin.ts 88.88% <ø> (ø)
... and 20 more

... and 12 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@robertu7 robertu7 merged commit 7802bf9 into develop Aug 23, 2023
3 of 4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/default-notice-settings branch August 23, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review & revise non-email side effects Revise default notification settings
2 participants