-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(notice): revise default notification settings #3547
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertu7
changed the title
feat(notice): revise default notification settings
WIP: feat(notice): revise default notification settings
Aug 18, 2023
This was
linked to
issues
Aug 18, 2023
robertu7
force-pushed
the
feat/default-notice-settings
branch
from
August 22, 2023 08:06
a711795
to
ade656d
Compare
robertu7
changed the title
WIP: feat(notice): revise default notification settings
feat(notice): revise default notification settings
Aug 22, 2023
robertu7
force-pushed
the
feat/default-notice-settings
branch
from
August 22, 2023 10:36
c22f1fb
to
dee6dcc
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #3547 +/- ##
===========================================
- Coverage 50.67% 49.39% -1.29%
===========================================
Files 521 519 -2
Lines 12743 12588 -155
Branches 2906 2879 -27
===========================================
- Hits 6458 6218 -240
- Misses 5664 5744 +80
- Partials 621 626 +5
☔ View full report in Codecov by Sentry. |
gary02
approved these changes
Aug 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
subscribed_article_new_comment
notice;--ignore
tolint
command;Note:
Some changes are inherited from #3529, will resolve conflicts later.