Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right margin bug in mobile style #181

Closed
5 of 11 tasks
rhinenoir opened this issue Mar 17, 2018 · 12 comments
Closed
5 of 11 tasks

Right margin bug in mobile style #181

rhinenoir opened this issue Mar 17, 2018 · 12 comments

Comments

@rhinenoir
Copy link

rhinenoir commented Mar 17, 2018

I agree and want to create new issue


Expected behavior

A right margin style in both mobile and PC mode

Actual behavior

NexT.Pisces

live demo

Steps to reproduce the behavior

set theme _config.yml

  1. mobile_layout_economy: true
  2. excerpt_description: true
    auto_excerpt: enable: true
  3. use <!— more —> tag in my post
  • Link to demo site with this issue: here
  • Link(s) to source code or any usefull link(s): N/A

Node.js and NPM Information

nothing wrong

Package dependencies Information

{
  "name": "hexo-site",
  "version": "0.0.0",
  "private": true,
  "hexo": {
    "version": "3.3.7"
  },
  "dependencies": {
    "crypto": "^1.0.1",
    "fs": "0.0.1-security",
    "hexo": "^3.2.0",
    "hexo-algolia": "^1.2.4",
    "hexo-deployer-git": "^0.3.0",
    "hexo-filter-mermaid": "^1.0.0",
    "hexo-generator-archive": "^0.1.4",
    "hexo-generator-category": "^0.1.3",
    "hexo-generator-feed": "^1.2.2",
    "hexo-generator-index": "^0.2.0",
    "hexo-generator-json-content": "^3.0.1",
    "hexo-generator-tag": "^0.2.0",
    "hexo-renderer-ejs": "^0.2.0",
    "hexo-renderer-markdown-it-plus": "^1.0.2",
    "hexo-renderer-stylus": "^0.3.1",
    "hexo-server": "^0.2.0",
    "hexo-tag-mermaid": "^1.0.0",
    "hexo-wordcount": "^3.0.2",
    "path": "^0.12.7",
    "puppeteer": "^1.1.1"
  },
  "devDependencies": {}
}

Hexo Information

Hexo version


Hexo Configuration

NexT Information

NexT Version:

  • Latest Master branch
  • Latest Release version
  • Old version

NexT Scheme:

  • All schemes
  • Muse
  • Mist
  • Pisces
  • Gemini

NexT Configuration:

mobile_layout_economy: true
auto_excerpt: enable: true

Other Information

@ivan-nginx ivan-nginx changed the title rhight margin bug in mobile style Right margin bug in mobile style Mar 17, 2018
@ivan-nginx ivan-nginx added the Bug label Mar 17, 2018
@ivan-nginx ivan-nginx mentioned this issue Mar 17, 2018
72 tasks
@sli1989 sli1989 mentioned this issue Mar 17, 2018
15 tasks
@sli1989
Copy link
Collaborator

sli1989 commented Mar 18, 2018

Why i can't reproduce this bug today? The demo site works fine as well...

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 18, 2018

Need to enable this option:

# Automatically Excerpt. Not recommend.
# Please use <!-- more --> in the post to control excerpt accurately.
auto_excerpt:
  enable: true
  length: 150

@sli1989 this is not bug releated to #182 fix, it's another bug.

@sli1989
Copy link
Collaborator

sli1989 commented Mar 18, 2018

Caused by mobile_layout_economy: true... I got it wrong.

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 18, 2018

This bug only can be catched in homepage with auto exerpt and mobile economy options — all auto exerpt text can't have CSS styles for left-right paddings/margins, so, text will be in full width. In mobile style, of course.

@sli1989
Copy link
Collaborator

sli1989 commented Mar 18, 2018

But mobile_layout_economy: false & auto_excerpt: enable: true works fine.

@ivan-nginx
Copy link
Member

Yes. And mobile_layout_economy: true & auto_excerpt: enable: true works not fine. This issue releated for this.

@rhinenoir
Copy link
Author

@sli1989 sorry, I temporarily return back to mobile_layout_economy: false now, the bug is comfirmed by @ivan-nginx

@rhinenoir
Copy link
Author

weird……I set economy false an deploy it so many times ,but it return back to the bad margin style and fail to come back normal

@sli1989
Copy link
Collaborator

sli1989 commented Mar 23, 2018

Try in V6+?

@stevenjoezhang
Copy link
Contributor

stevenjoezhang commented Dec 25, 2018

Another bug is that the line numbers will be converted to 123456789101112131415161718 in post excerpt by content.substring(), which is mentioned in #333. Should remove all <span class="line">.

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 16, 2019

It's same as in #696. Or not?

@ivan-nginx ivan-nginx reopened this Mar 16, 2019
@stevenjoezhang
Copy link
Contributor

@ivan-nginx They're different. This bug is caused by missing <p> tag in post excerpt, and was already resolved.

@theme-next theme-next locked as resolved and limited conversation to collaborators Apr 1, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this issue Nov 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants