Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove keywords in Theme-Next #168

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Remove keywords in Theme-Next #168

merged 2 commits into from
Mar 15, 2018

Conversation

xu-song
Copy link
Contributor

@xu-song xu-song commented Mar 14, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes have been added (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs have been added / updated (for bug fixes / features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

There is keywords configuration both in Hexo and Theme-Next.

  • Hexo generates keywords from page.keywords, page.tags and config.keywords. source code
  • Next generates keywords from page.keywords, page.tags and theme.keywords. source code

What is the new behavior?

Remove keywords configuration in Theme-Next.
It works fine with one configuration.

Does this PR introduce a breaking change?

  • Yes.
  • No.

@ivan-nginx
Copy link
Member

ivan-nginx commented Mar 15, 2018

Addition to #115 pull.


So, after this pull there are breaking changes — need to move keywords from NexT config to Hexo config:

hexo_dir/themes/next/_config.yml

-# Set default keywords (Use a comma to separate)
-keywords: "Hexo, NexT"

hexo_dir/_config.yml

+# Set default keywords (Use a comma to separate)
+keywords: "Hexo, NexT"

And this keywords will be for homepage only.

For other posts there are no breaking changes and tags/keywords can be setted in old style:

...
tags: [Sidebar, TOC, test]
...

OR

...
tags:
  - Sidebar
  - TOC
  - test
...

@ivan-nginx ivan-nginx merged commit 67892b2 into theme-next:master Mar 15, 2018
@ivan-nginx ivan-nginx mentioned this pull request Mar 15, 2018
15 tasks
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
* Update _config.yml

* remove keywords in theme-next
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants