Fix #508 Reward comment position bug #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevenjoezhang
force-pushed
the
master
branch
2 times, most recently
from
666aa6e
to
e699386
Compare
ivan-nginx
reviewed
Dec 29, 2018
| @@ -121,7 +121,7 @@ | |||
| {% set ccType = 'licenses/' + theme.creative_commons.license + '/4.0/' %} | |||
| {% endif %} | |||
| {% set ccURL = 'https://creativecommons.org/' + ccType %} | |||
| {% set ccImage = '<img src="' + url_for(theme.images) + '/cc-' + theme.creative_commons.license + '.svg" alt="Creative Commons" />' %} | |||
| {% set ccImage = '<img src="' + url_for(theme.images + '/cc-' + theme.creative_commons.license + '.svg') + '" alt="Creative Commons"/>' %} | |||
There was a problem hiding this comment.
Are you sure url_for will work rightly here?
There was a problem hiding this comment.
Yes, they're the same.
ivan-nginx
approved these changes
Dec 29, 2018
tongluyang
pushed a commit
to tongluyang/hexo-theme-next
that referenced
this pull request
Nov 19, 2019
* format code * update CDN URLs * fix theme-next#269 * fix theme-next#508
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number(s): #508
What is the new behavior?
Description about this pull, in several words...
How to use?
In NexT
_config.yml:Does this PR introduce a breaking change?