Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Likely share #678

Merged
merged 2 commits into from
Mar 12, 2019
Merged

Likely share #678

merged 2 commits into from
Mar 12, 2019

Conversation

1v9
Copy link
Member

@1v9 1v9 commented Mar 11, 2019 •
edited

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for new features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #491

What is the new behavior?

  • Screenshots with this changes:
    批注 2019-03-12 073501.jpg

How to use?

In NexT _config.yml:

likely:
  enable: true
  look: big
  networks:
    twitter: Tweet
    facebook: Share
    linkedin: Link
    gplus: Plus
    vkontakte: Share
    odnoklassniki: Class
    telegram: Send
    whatsapp: Send
    pinterest: Pin

Does this PR introduce a breaking change?

  • Yes.
  • No.

@1v9 1v9 requested review from stevenjoezhang, ivan-nginx and maple3142 and removed request for stevenjoezhang and ivan-nginx March 11, 2019 23:42
@1v9 1v9 added this to the v7.1.0 milestone Mar 11, 2019
@1v9 1v9 mentioned this pull request Mar 11, 2019
Closed
@stevenjoezhang
Copy link
Contributor

Good job 🐸

The only problem is _config.yml is getting even longer, almost 1200 lines now 😂

@1v9
Copy link
Member Author

1v9 commented Mar 12, 2019

not friendly to newbie 😥

@1v9
Copy link
Member Author

1v9 commented Mar 12, 2019

I will update docs later.

@1v9 1v9 merged commit 82edcff into theme-next:master Mar 12, 2019
@1v9 1v9 deleted the likely branch March 12, 2019 09:36
@1v9 1v9 mentioned this pull request Mar 12, 2019
Merged
1v9 added a commit to theme-next/theme-next.org that referenced this pull request Mar 12, 2019
@1v9
Add likely doc (#29)
a6cbc7f 
* after theme-next/hexo-theme-next#678
@ivan-nginx ivan-nginx mentioned this pull request Mar 12, 2019
Closed
72 tasks
@ivan-nginx ivan-nginx changed the title Feat: Add likely share support Added likely share support. Mar 15, 2019
@liolok liolok changed the title Added likely share support. Add likely share support. Mar 31, 2019
@liolok liolok changed the title Add likely share support. Likely share Mar 31, 2019
tongluyang pushed a commit to tongluyang/hexo-theme-next that referenced this pull request Nov 19, 2019
@1v9
Feat: Add likely share support (theme-next#678)
b270f6a 
* Feat: Add likely share support

* theme-next#491

* update cdn
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stevenjoezhang stevenjoezhang stevenjoezhang approved these changes

@maple3142 maple3142 Awaiting requested review from maple3142

Assignees
No one assigned
Labels
🌟 New Feature 🎯 Roadmap 🔌 3rd Party Plugin
Projects
None yet
Milestone
v7.1.0
Development

Successfully merging this pull request may close these issues.

Add support for social buttons — Likely
2 participants
@1v9 @stevenjoezhang