Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load velocity only if motion is enabled #951

Merged
merged 15 commits into from Jul 10, 2019
Merged

Load velocity only if motion is enabled #951

merged 15 commits into from Jul 10, 2019

Conversation

stevenjoezhang
Copy link
Contributor

@stevenjoezhang stevenjoezhang commented Jul 7, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

  • The commit message follows our guidelines.
  • Tests for the changes was maked (for bug fixes / features).
    • Muse | Mist have been tested.
    • Pisces | Gemini have been tested.
  • Docs in NexT website have been added / updated (for features).

PR Type

What kind of change does this PR introduce?

  • Bugfix.
  • Feature.
  • Code style update (formatting, local variables).
  • Refactoring (no functional changes, no api changes).
  • Build related changes.
  • CI related changes.
  • Documentation content changes.
  • Other... Please describe:

What is the current behavior?

Issue resolved: #113

iissnan/hexo-theme-next#803

Sidebar could be placed in the left/right for all schemes.
Sidebar could be displayed without animation.

What is the new behavior?

  • Screenshots with this changes: N/A
  • Link to demo site with this changes: N/A

How to use?

In NexT _config.yml:

...

Does this PR introduce a breaking change?

  • Yes.
  • No.

@stevenjoezhang stevenjoezhang added this to the v7.3.0 milestone Jul 7, 2019
@1v9 1v9 changed the title Escape html in the author parameter Escape html in the author parameter of reward.swig Jul 7, 2019
1v9
1v9 previously approved these changes Jul 7, 2019
@1v9 1v9 self-requested a review July 7, 2019 13:39
@1v9 1v9 dismissed their stale review July 7, 2019 13:39

{{ author.text }} will be ignored

@stevenjoezhang stevenjoezhang changed the title Escape html in the author parameter of reward.swig PalPay donate support Jul 7, 2019
@1v9

This comment has been minimized.

@stevenjoezhang stevenjoezhang changed the title PalPay donate support Load velocity only if motion is enabled Jul 7, 2019
@stevenjoezhang

This comment has been minimized.

@1v9
Copy link
Member

1v9 commented Jul 7, 2019

{%
set js_commons = [
'utils.js',
'motion.js'
]
%}
{% for common in js_commons %}
<script src="{{ url_for(theme.js) }}/{{ common }}?v={{ version }}"></script>
{% endfor %}

Yes, countless velocity... like sidebarToggleMotion

@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@1v9
Copy link
Member

1v9 commented Jul 9, 2019

I have tested several times, now we can say goodbye to velocity when motion is disable.

@stevenjoezhang
Copy link
Contributor Author

Next step: say goodbye to jQuery 😂

@stevenjoezhang stevenjoezhang requested a review from 1v9 July 9, 2019 14:27
@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@theme-next theme-next deleted a comment Jul 9, 2019
@stevenjoezhang
Copy link
Contributor Author

I'll merge this PR first. For the issues it may cause (about motion / sidebar), I will solve them in the future when I refactor sidebar-dimmer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants