Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSS build scripts #2

Closed
justintadlock opened this issue Mar 5, 2018 · 4 comments
Closed

CSS build scripts #2

justintadlock opened this issue Mar 5, 2018 · 4 comments

Comments

@justintadlock
Copy link
Member

justintadlock commented Mar 5, 2018

I'm fairly certain, we'll be using npm-scripts at this point rather than something like Gulp or Grunt. I'm also fairly certain we'll default to handling SCSS or similar syntax.

The following is a rundown of some of the CSS-related build scripts that we might utilize. These were copied over from our Slack channel discussion.

What we need to do is come up with a solid set of scripts that would be useful in most theme projects.

Working with the styles:

Working with the files (probably some crossover with JS files):

@brettsmason
Copy link
Collaborator

If it helps I read a nice article on moving from SASS to PostCSS the other day.

I also think Webpack is worth considering. Its pretty much required for JavaScript work these days, and looks like the latest version has been simplified a little to setup.

@samikeijonen
Copy link
Collaborator

Also linking conversation in Underscores about linting and compiling.

I haven't tested using only npm-scripts. I'm 100% sure it work for CSS. But not sure about JS, SVG icons, and images.

Let's open separate issues when there is something to test.

justintadlock added a commit that referenced this issue Mar 7, 2018
@brettsmason
Copy link
Collaborator

I've put a bit of work in to getting a full Webpack build chain setup here. Would it be of interest if I finish it off and get a PR setup, or would you rather stick with purely NPM scripts?

If not I'll save it for my own fork as I think I want to go with that solution personally 😄

@justintadlock
Copy link
Member Author

Fixed. See: #22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants