Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding phpcs.xml file #7

Closed
samikeijonen opened this issue Mar 5, 2018 · 4 comments
Closed

Adding phpcs.xml file #7

samikeijonen opened this issue Mar 5, 2018 · 4 comments
Labels
Enhancement New feature or request. Help Wanted Extra attention is needed.
Milestone

Comments

@samikeijonen
Copy link
Collaborator

Project code should be checked using PHPCS. In most cases there should be custom phpcs.xml for creating custom ruleset good for project.

Couple of examples:

This way we can also check PHP compatibility for different versions.

This was referenced Mar 5, 2018
@samikeijonen
Copy link
Collaborator Author

I'm pretty happy about the phpcs.xml at the moment.

@justintadlock justintadlock added Enhancement New feature or request. Help Wanted Extra attention is needed. labels Jun 25, 2018
@justintadlock justintadlock added this to the 1.0.0 milestone Aug 6, 2018
@justintadlock
Copy link
Member

This is probably one of the biggest projects left for the theme before the 1.0.0 release. We need to pay attention to the WPTRT coding standards project. We'll want to take advantage of that and integrate it with any custom rules.

@GaryJones
Copy link

Please name it .phpcs.xml.dist, and add phpcs.xml and .phpcs.xml to the .gitignore file.

This allows the distributed config file to be trumped by a local config file.

@samikeijonen I'll add some feedback about your config file, to your repo :-)

@justintadlock
Copy link
Member

Closing this specific ticket as fixed. We should open new tickets to address other issues.

In particular, our end goal would be to utilize the WP TRT standards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request. Help Wanted Extra attention is needed.
Projects
None yet
Development

No branches or pull requests

3 participants