feat : support nepali language #56
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
themisir
requested changes
Feb 1, 2024
| @@ -0,0 +1,26 @@ | |||
| class NepaliLangUtils { | |||
There was a problem hiding this comment.
Let's please move this into ne.dart
|
|
||
| for (int i = 0; i < numberString.length; i++) { | ||
| int digit = int.parse(numberString[i]); | ||
| result += nepaliDigits[digit]; |
There was a problem hiding this comment.
Here we can use StringBuffer() instead of string concatenation to be efficient with memory
| String numberString = num.toString(); | ||
|
|
||
| for (int i = 0; i < numberString.length; i++) { | ||
| int digit = int.parse(numberString[i]); |
There was a problem hiding this comment.
It's minor optimization, but things can add up, I can not ensure any specific usage patterns from users so assuming a screen with multiple number inputs, when a language change occurs these calculations will add up.
I think alongside with the StringBuffer, we can use numberString.charCodeAt(i) - '0'.charCodeAt(0) would be faster to calculate digit index.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.