Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove KireiCake #195

Closed
MarvNC opened this issue Jul 19, 2023 · 1 comment · Fixed by #305
Closed

Remove KireiCake #195

MarvNC opened this issue Jul 19, 2023 · 1 comment · Fixed by #305
Labels
kind/enhancement The issue or PR is a new feature or request

Comments

@MarvNC
Copy link
Member

MarvNC commented Jul 19, 2023

FooSoft#1608

A given entry usually has a handful of these qualities:

straight up wrong
not entirely wrong, but not particularly accurate
very incomplete
has typos / formatting errors / inconsistencies
vastly inferior to the jmdict entry
vastly inferior to the jj entries
very apparent / unneeded A+B

Thermosphere brought this up a while ago, and I feel like it should be removed especially as JMDict has continuously been improving and there isn't much point in KireiCake at all given its inaccuracies.

@MarvNC MarvNC added the kind/enhancement The issue or PR is a new feature or request label Jul 19, 2023
MarvNC added a commit to MarvNC/yomitan that referenced this issue Nov 3, 2023
@Kuuuube
Copy link
Member

Kuuuube commented Jun 22, 2024

To add to this, I ran a diff of kireicake vs the latest jmdict and a few very old versions of jmdict. There's 7184 terms missing from the latest jmdict that are in kireicake. BUT almost all of these are deleted or rejected entries from jmdict.

Entries deleted or rejected from jmdict are not good to have. They often include completely useless information, words that were mistakenly added and don't actually exist, or completely wrong information.

The vast majority of entries exist in both kireicake and jmdict. However, jmdict has constant updates. There are mistakes in jmdict but over the years those mistakes have been cut down enormously. Kireicake is not updated and still contains every mistake that jmdict from years ago did.

Kireicake also pollutes Yomitan's furigana generator with ridiculous ruby text for words. For example, every compound word that contains both katakana and kanji, kireicake will show furigana instead of katakana and add furigana above the hiragana with the katakana. Even just having kireicake enabled at any priority on your dictionary list can cause these issues.

Having kireicake dictionary will only serve to mislead and confuse. I highly recommend any users of kireicake to switch to either Jitendex or use an updated version of JMdict (if you like the style of old jmdict/kireicake formatting theres a legacy formatted version available too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement The issue or PR is a new feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants