Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eslint rule updates #673

Merged
merged 8 commits into from
Feb 15, 2024

Conversation

toasted-nutbread
Copy link

@toasted-nutbread toasted-nutbread commented Feb 11, 2024

The general process I have tried to follow for the recent eslint rule updates, including this one, is to try to enable everything, and then disable things which don't match the existing style for the most part.

Resolves #615.

@toasted-nutbread toasted-nutbread requested a review from a team as a code owner February 11, 2024 20:07
Copy link

github-actions bot commented Feb 11, 2024

✔️ No visual differences introduced by this PR.

View Playwright Report (note: open the "playwright-report" artifact)

Copy link
Author

@toasted-nutbread toasted-nutbread left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left comments on a few of the noteworthy things I ran into while making this update. @djahandarie feel free to read them and just close them, as I don't have actions for them aside from just noting them.

Beyond that, if we run into any future issues with these rules causing trouble, I'm not opposed to disabling the problematic ones.

dev/schema-validate.js Show resolved Hide resolved
dev/data-error.js Show resolved Hide resolved
dev/build-libs.js Show resolved Hide resolved
ext/js/dom/selector-observer.js Show resolved Hide resolved
ext/js/pages/permissions-main.js Show resolved Hide resolved
ext/js/pages/settings/anki-controller.js Show resolved Hide resolved
ext/js/pages/settings/settings-controller.js Show resolved Hide resolved
test/document-util.test.js Show resolved Hide resolved
test/fixtures/anki-template-renderer-test.js Show resolved Hide resolved
test/fixtures/translator-test.js Show resolved Hide resolved
@djahandarie djahandarie added this pull request to the merge queue Feb 15, 2024
Merged via the queue into themoeway:master with commit 6bf7b00 Feb 15, 2024
7 checks passed
@djahandarie djahandarie added the kind/meta The issue or PR is meta label Feb 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/meta The issue or PR is meta
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Introduce more lints from eslint-plugin-unicorn and eslint-plugin-sonarjs?
2 participants