Allow ordering term dictionaries with the same priority using the ui order #981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuuuube
added
kind/enhancement
Kuuuube
added
kind/bug
|
Changed to only sort by score near the end to preserve support for sorting definitions by score within the same dictionary. |
jamesmaa
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allowing dictionaries to be ordered by term score severely cripples the reasoning for dictionary ordering in popups and search that the user will see.
I've looked through the original intended use of this (from 8 years ago) and it appears to be redundant now. Previously this was also used to sort different words and is very tailored towards jmdict (or nowadays jitendex) to help sort more popular words over less popular ones. This is no longer how we sort words. Most other dictionaries don't have tagging like this so jmdict dictionaries almost always get the highest score and go to the top unless they are set to lower priority.
This does not make sense at all to do in the current landscape with all the different dictionaries being used and with other language support.