-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move dictionary up and down buttons out of kebab menu #971
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does "move to.." functionally do? Is it just the dictionary display order in settings?
@@ -62,6 +62,8 @@ | |||
</button> | |||
</div> | |||
<input type="number" step="1" class="short-height dictionary-priority"> | |||
<button type="button" class="icon-button" id="dictionary-move-up" data-menu-action="moveUp"><span class="icon-button-inner"><span class="icon" data-icon="up-chevron"></span></span></button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there alt text that we can add to help confused users?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If users are getting confused about what up and down arrows do I'm concerned about them.
Due to the size of the arrows we cant really add a "down" label. Could do "Up" and "Dn" maybe.
Yes, it moves the dictionary to number in the list that you input. |
Moved dict priority setting under advanced. Expecting this to be merged alongside or after #981. Without that change this ui doesn't make sense. |
Depends on #981. It doesn't make sense to have this ui unless the dict order sorting works properly.
Repositioning dictionaries is a huge pain right now and requires two button clicks to move a dictionary a single space up. Using
Move to...
or having to repeatedly hit the menu button and then move up or down is not a good user experience.Ideally we want something like drag and drop but I think this change helps a bit before we get to that.
Screenshot:
Tested on Firefox, Chromium, Firefox Android, and Kiwi browser.