Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect cmd_build creation for VCS #240

Closed
alina-andreevna opened this issue Jul 23, 2023 · 4 comments
Closed

Incorrect cmd_build creation for VCS #240

alina-andreevna opened this issue Jul 23, 2023 · 4 comments

Comments

@alina-andreevna
Copy link

  1. top level module name is not provided in cmd_build line. This is potential problem for simulation when user top module is not matched than found in compile list by vcs
  2. timescale parameter syntax in vcs timescale=1ns/1ps, not timescale 1ns/1ps. Also it should be part of cmd_build, not common cmd
@alina-andreevna
Copy link
Author

I have a patch for this, but can not publish my branch:

ERROR: Permission to themperek/cocotb-test.git denied to alina-andreevna.
fatal: Could not read from remote repository.

Please make sure you have the correct access rights     
and the repository exists.

@themperek
Copy link
Owner

You need to fork this git repository and commit there and open pull request. Worst case province the code here.

boryahlopunov added a commit to boryahlopunov/cocotb-test that referenced this issue Aug 9, 2023
themperek#240
fixed issue with wrong topmodule and timescale in VCS
boryahlopunov added a commit to boryahlopunov/cocotb-test that referenced this issue Aug 9, 2023
themperek#240
fixed VCS propagation of timescale and topmodule
@boryahlopunov
Copy link
Contributor

Hi, ive made a fix for this issue.
please find it here
boryahlopunov#1

themperek pushed a commit that referenced this issue Aug 11, 2023
#240
fixed VCS propagation of timescale and topmodule
@themperek
Copy link
Owner

Close with #244

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants