This repository has been archived by the owner on Dec 29, 2018. It is now read-only.

Payout distribution is broken #26

Closed

pmconrad opened this issue Nov 23, 2017 · 0 comments

Assignees

Labels

Milestone

Collaborator

pmconrad commented Nov 23, 2017

pay_to_* assumes that payouts are always in the same asset type
Splitting payouts among multiple users can result in some satoshis being left over, which are simply lost by the current implementation. As a result, the total_supply global variable gets out of sync.
Payout logic after changes in the payee lists is broken.

https://github.com/themuseblockchain/Muse-Source/blob/HF_1/libraries/chain/database.cpp#L1648
https://github.com/themuseblockchain/Muse-Source/blob/HF_1/libraries/chain/database.cpp#L1678
https://github.com/themuseblockchain/Muse-Source/blob/HF_1/libraries/chain/muse_evaluator.cpp#L365-L427

pmconrad added bug hardfork labels

pmconrad added this to the 0.2.0 milestone

pmconrad added a commit to pmconrad/Muse-Source that referenced this issue


          Fixed issue themuseblockchain#26, part 3

be65782

pmconrad closed this as completed

pmconrad self-assigned this

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.