Fix to migration 3.4.4 to newer (absent EngineMode enforce the Cluste… #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r deletion!), forwarding to CloudWatch was not implemented.
aaronwalker
requested changes
Jun 14, 2024
aurora-mysql.cfhighlander.rb
Outdated
| @@ -35,5 +35,7 @@ | |||
| ComponentParam 'NamespaceId' if defined? service_discovery | |||
|
|
|||
| ComponentParam 'EnableReplicaAutoScaling', 'false', isGlobal: true | |||
|
|
|||
| ComponentParam 'EnableCloudwatchLogsExports', defined?(log_exports) ? log_exports : '', isGlobal: true | |||
There was a problem hiding this comment.
@petlitskiy The EnableCloudwatchLogsExports param does not need to be a global parameter can you please remove the isGlobal from thr parameter definition can you also change for the EnableReplicaAutoScaling parameter as well
There was a problem hiding this comment.
@aaronwalker Done.
|
@aaronwalker Featured tested and it is working as expected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to migration v3.4.4 to newer (absent EngineMode enforce the Cluster v3.4.4 deletions!), forwarding to CloudWatch was not implemented.