Make these styles available once and for all to all the people #224
Conversation
|
I like it. |
|
LGTM. Do we feel like we should take a look at test links before pushing to each site? |
|
@spra85 @kand We need to do a full vetting of each site before installing. Will need to remove all campaign-display declarations in local styles (or at least the bits that are duplicates of this PR). I created the PR bc I couldn't stand to write them again while working on the ClickHole video experience. I can make some tickets for this work if anyone wants to pick it up and run with it. |
| font-family: 'Helvetica', Arial, sans-serif; | ||
| font-size: 10px; | ||
| text-transform: uppercase; | ||
| .inner a { |
There was a problem hiding this comment.
Want to note, .inner seems like too generic a class name, something else might style this on accident. But that change is much bigger than this PR and includes omni.
There was a problem hiding this comment.
confirmed, CH is picking up .inner twice:
| @@ -15,7 +15,6 @@ campaign-display { | |||
| } | |||
| } | |||
| .campaign-display-logo { | |||
| margin-left: 15px; | |||
There was a problem hiding this comment.
revert this please
|
@kand no, still need to update clickhole and avclub |
…aign-display-styles
…lements into campaign-display-styles
…aign-display-styles
…aign-display-styles
@theonion/front-end Long time comin.