Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(build): Move needed devDependencies to dependencies #89

Merged
merged 2 commits into from
Sep 12, 2020

Conversation

danielsharvey
Copy link
Collaborator

Several modules were included as devDependencies but should be dependencies; closes #88

@danielsharvey
Copy link
Collaborator Author

@theoomoregbee There still seem to be something odd going on - Travis CI has been triggered but not noted here?

See https://travis-ci.org/github/theoomoregbee/sails-hook-swagger-generator/builds/725459962

Also commitlint seems to be hung "waiting"?

Copy link
Owner

@theoomoregbee theoomoregbee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will take a look with what is wrong with the commit bot.

Left a minor comment

package.json Outdated Show resolved Hide resolved
@theoomoregbee
Copy link
Owner

@theoomoregbee
Copy link
Owner

https://github.com/z0al/commitlint-bot is deprecated and not maintained again, updated to use https://github.com/apps/semantic-pull-requests

@theoomoregbee
Copy link
Owner

theoomoregbee commented Sep 10, 2020

FYI: I closed and open to see if it will trigger the new bot. I guess it's for new PRs

@danielsharvey
Copy link
Collaborator Author

@theoomoregbee Just a note that the TravisCI link above show the build OK, but it is not listed as a check for the PR:

image

@danielsharvey danielsharvey merged commit a92f705 into master Sep 12, 2020
@danielsharvey danielsharvey deleted the fix-88 branch September 12, 2020 13:53
@theoomoregbee
Copy link
Owner

🎉 This PR is included in version 3.2.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find module 'lodash/assign'
2 participants