WIP : 1115/i18n : Upgrade ngx-moment + Fix Function expressions are not sup… #1197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ported in decorators
francoisno
requested changes
Feb 27, 2021
There was a problem hiding this comment.
Hi @cedricjimenezst thanks a lot for the PR, I will test it in the next days!
(And I'll be glad to work on #1115 with you if you're interested.)
Concerning this PR, it is no big deal but could you refactor it slightly (branch name, commit message, signed commit) to fit project conventions please? (https://github.com/theopenconversationkit/tock/blob/master/CONTRIBUTING.md)
Please let me know if you have questions.
|
@francoisno can I merge this MR ? |
francoisno
requested changes
Mar 20, 2021
| @@ -36,6 +36,11 @@ import {NbThemeModule, NbRouteTabsetModule, NbCardModule, NbButtonModule, NbSele | |||
| import {ThemeModule} from "../theme/theme.module"; | |||
| import { NgxEchartsModule } from 'ngx-echarts'; | |||
| import {NgbModule} from '@ng-bootstrap/ng-bootstrap'; | |||
| import {ChartsModule} from "ng2-charts"; | |||
There was a problem hiding this comment.
This import/module breaks the build (at least after rebasing from master).
|
Merged manually. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ported in decorators